Tracing: end HTTP spans when body is fully consumed, add missing methods for OpenAI instrumentation #39381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
trask,
alzimmermsft,
srnagar,
anuchandy,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
github-actions
bot
added
Azure.Core
lmolkova
commented
Mar 25, 2024
| @@ -102,7 +102,7 @@ public Context start(String spanName, StartSpanOptions options, Context context) | |||
| return startSuppressedSpan(context); | |||
| } | |||
| context = unsuppress(context); | |||
| if (spanKind == SpanKind.INTERNAL && !context.getData(CLIENT_METHOD_CALL_FLAG).isPresent()) { | |||
| if (isInternalOrClientSpan(spanKind) && !context.getData(CLIENT_METHOD_CALL_FLAG).isPresent()) { | |||
There was a problem hiding this comment.
needed for suppression when we have
- Client (public API) -> Client (public API) -> Client (HTTP)
- Client (public API) -> Internal (public API) -> Client (HTTP)
spans
...ng-opentelemetry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracer.java
Show resolved
Hide resolved
...lemetry/src/test/java/com/azure/core/tracing/opentelemetry/OpenTelemetryHttpPolicyTests.java
Show resolved
Hide resolved
...zure-core/src/main/java/com/azure/core/implementation/http/policy/InstrumentationPolicy.java
Show resolved
Hide resolved
...zure-core/src/main/java/com/azure/core/implementation/http/policy/InstrumentationPolicy.java
Show resolved
Hide resolved
...zure-core/src/main/java/com/azure/core/implementation/http/policy/InstrumentationPolicy.java
Show resolved
Hide resolved
alzimmermsft
approved these changes
Mar 26, 2024
...zure-core/src/main/java/com/azure/core/implementation/http/policy/InstrumentationPolicy.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tracer.isRecording- useful when we want to avoid overhead for sampled-out spans (e.g. we don't need to wrap the HTTP response if span is not sampled in)Tracer.setAttribute(String, Object, Context)to supportdoubleattributes needed for OpenAI, but we'll also likely needString[]