Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make azure-json transitive in azure-core module-info #39432

Merged

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Mar 27, 2024

Description

Make the azure-json requires in the module-info for azure-core transitive so downstream libraries don't need to add it as required in their module-info as well.

Libraries already requiring azure-json in their module-info will need to be updated after azure-core releases as removing it now may break their build as they depend on released versions of azure-core which don't perform transitive requires.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Azure.Core azure-core labels Mar 27, 2024
@alzimmermsft alzimmermsft self-assigned this Mar 27, 2024
@alzimmermsft alzimmermsft merged commit 029ceb7 into Azure:main Mar 27, 2024
37 checks passed
@alzimmermsft alzimmermsft deleted the AzCore_MakeAzureJsonTransitive branch March 27, 2024 21:53
@srnagar
Copy link
Member

srnagar commented Mar 27, 2024

@billwert Identity should now be able to use azure-json without changing module-info.java

@billwert
Copy link
Contributor

Yup. I'll pull it in before we release next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants