Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate azure-analytics-defender-easm to azure-json #41161

Merged

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jul 16, 2024

link #40614

Another attempt on easm, as service have no response on task #39862

spec target Azure/azure-rest-api-specs#29839
I've cleaned src/main before regen.

Service removed subscriptionId, resourceGroupName, workspaceName parameters from their typespec server endpoint. Now the endpoint contains all of them, as e.g. https://<host>/subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/workspaces/<workspaceName>/. This is the cause of change in client builder.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft weidongxu-microsoft changed the title test, migrate azure json easm test, migrate azure-json easm Jul 16, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-analytics-defender-easm

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-analytics-defender-easm

@weidongxu-microsoft
Copy link
Member Author

/azp run java - easm - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft weidongxu-microsoft changed the title test, migrate azure-json easm test, migrate azure-analytics-defender-easm to azure-json Aug 5, 2024
@weidongxu-microsoft weidongxu-microsoft changed the title test, migrate azure-analytics-defender-easm to azure-json migrate azure-analytics-defender-easm to azure-json Aug 5, 2024
@weidongxu-microsoft weidongxu-microsoft merged commit 4249665 into Azure:main Aug 8, 2024
21 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the migrate-azure-json_easm branch August 8, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants