-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate azure-analytics-defender-easm to azure-json #41161
Merged
weidongxu-microsoft
merged 12 commits into
Azure:main
from
weidongxu-microsoft:migrate-azure-json_easm
Aug 8, 2024
Merged
migrate azure-analytics-defender-easm to azure-json #41161
weidongxu-microsoft
merged 12 commits into
Azure:main
from
weidongxu-microsoft:migrate-azure-json_easm
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weidongxu-microsoft
changed the title
test, migrate azure json easm
test, migrate azure-json easm
Jul 16, 2024
API change check APIView has identified API level changes in this PR and created following API reviews. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
/azp run java - easm - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
weidongxu-microsoft
changed the title
test, migrate azure-json easm
test, migrate azure-analytics-defender-easm to azure-json
Aug 5, 2024
weidongxu-microsoft
changed the title
test, migrate azure-analytics-defender-easm to azure-json
migrate azure-analytics-defender-easm to azure-json
Aug 5, 2024
weidongxu-microsoft
requested review from
joshfree,
srnagar,
anuchandy,
conniey,
lmolkova and
JonathanGiles
as code owners
August 5, 2024 06:33
vcolin7
approved these changes
Aug 7, 2024
alzimmermsft
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link #40614
Another attempt on easm, as service have no response on task #39862
spec target Azure/azure-rest-api-specs#29839
I've cleaned src/main before regen.
Service removed
subscriptionId
,resourceGroupName
,workspaceName
parameters from their typespec server endpoint. Now theendpoint
contains all of them, as e.g.https://<host>/subscriptions/<subscriptionId>/resourceGroups/<resourceGroupName>/workspaces/<workspaceName>/
. This is the cause of change in client builder.Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines