Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai, update tsp-location commitId to 0.60 #41844

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Sep 13, 2024

There is stricter check on versioning in typespec 0.60

We need to take in the fix

-alias ChatMessageContent = string | ChatMessageContentItem[];
+@doc("The contents of the user message, with available input types varying by selected model.")
+union ChatMessageContent {
+  string,
+
+  @added(ServiceApiVersions.v2024_02_15_Preview)
+  ChatMessageContentItem[],
+}

on "specification/cognitiveservices/OpenAI.Inference/models/completions/chat_messages.tsp".

Otherwise there will be (valid) error

/mnt/vss/_work/1/s/azure-sdk-for-java/sdk/openai/azure-ai-openai/TempTypeSpecFiles/OpenAI.Inference/models/completions/chat_messages.tsp:114:3 - error @typespec/versioning/incompatible-versioned-reference: 'Azure.OpenAI.ChatRequestUserMessage.content' was added in version 'v2023_05_15' but referencing type 'Azure.OpenAI.ChatMessageContentItem' added in version 'v2024_02_15_Preview'.

commit on spec repo

openai, update tsp commit id to 0.60
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft
Copy link
Member Author

/azp run java - openai - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft weidongxu-microsoft merged commit ed4cc67 into Azure:main Sep 14, 2024
27 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the openai_update-commit-id-to-0.60 branch September 14, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants