Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, mongocluster, update commit ID after 0.61 #42297

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Oct 11, 2024

change on client.tsp required for 0.61
https://github.com/Azure/azure-rest-api-specs/pull/30955/files#diff-23030ecfb6e04a330fa7fb410200f83f78df6913f26a09755f09083ab697e4c5

without it compiler throw error
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4223227&view=logs&j=c28f120c-e125-5ec5-8d4c-ba1a4d871fcc&t=b83a11c4-9f3c-5115-167f-68dcfe6f5445

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@XiaofeiCao XiaofeiCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why csharp configuration is affecting us..

@weidongxu-microsoft
Copy link
Member Author

weidongxu-microsoft commented Oct 12, 2024

Wonder why csharp configuration is affecting us..

It's not the clientName. It is the 2 PublicNetworkAccess in 2 namespace (that compiler report ambiguous).

- @@clientName(PublicNetworkAccess,
+ @@clientName(Microsoft.DocumentDB.PublicNetworkAccess,

@weidongxu-microsoft weidongxu-microsoft merged commit 2019ef1 into Azure:main Oct 12, 2024
25 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_mongocluster-update-commit branch October 12, 2024 02:08
@XiaofeiCao
Copy link
Contributor

Ah, it's a bug fix for csharp configuration. I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants