[Bug] CFP Skipping Changes #43788
Open
[Bug] CFP Skipping Changes #43788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…to tvaron3/changeFeedExhaustedRUs
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simorenoh
reviewed
Jan 21, 2025
...c/test/java/com/azure/cosmos/rx/changefeed/pkversion/IncrementalChangeFeedProcessorTest.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Jan 21, 2025
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosContainerChangeFeedTest.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Jan 21, 2025
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosContainerChangeFeedTest.java
Outdated
Show resolved
Hide resolved
jeet1995
reviewed
Jan 21, 2025
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosContainerChangeFeedTest.java
Outdated
Show resolved
Hide resolved
jeet1995
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Feed Processor could skip records if there is throttling on the lease container and some other timing conditions. Change Feed keeps running after receiving a page and attempts to acquire all results. The continuation token gets updated and because it is a shared reference between change feed fetcher and partition processor, some records get skipped without being returned. Additionally, Change Feed Processor is not limiting one request at a time.
Solution
Create a deep copy of the CosmosChangeFeedRequestOptions. Moving the take(1, true) call down to the queryChangeFeed call to correctly only prefetch one page at a time.
Testing
Validated change by using queryChangeFeed with and without take(1,true)
More context: #43701