Block ChangeFeedMode interoperability for ChangeFeedProcessor.
#43798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Epk-Range and AllVersionAndDeletes based lease.
jeet1995
changed the title
|
API change check API changes are not detected in this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeet1995
changed the title
…ockAllVersionsAndDeletesForPkRangeBasedLease
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeet1995
changed the title
ChangeFeedMode interoperability for ChangeFeedProcessor.
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FabianMeiswinkel
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to block a customer leveraging the Change Feed Processor to switch between
LatestVersionandAllVersionsAndDeleteschange feed mode for the same lease prefix. The context behind this change is whenEPK_RANGE_BASED_LEASEis left behind byLatestVersion-AllVersionsAndDeletespicks up the lease silently (no hang per se) - we don't understand the repercussions here or functional validity. WhenPK_RANGE_BASED_LEASEis left behind,AllVersionsAndDeletesdoesn't detect it and creates its own lease which is also weird behavior.During the bootstrap of
ChangeFeedProcessor, the presence of leases with the same lease prefix is checked forPARTITION_KEY_BASED_LEASEwhen anAllVersionsAndDeletesworkload is started. If such is the case, then the bootstrap throws anIllegalStateExceptionas aPARTITION_KEY_BASED_LEASEis only applicable forLatestVersionchange feed mode. Likewise, if aLatestVersionworkload is started with thehandleChangesmethod, the presence ofEPK_RANGE_BASED_LEASEis checked, which if present, throws anIllegalStateException. These validations will look for a lease with the same lease prefix as the workload being started.This PR is a follow up to this - #38740 which introduced blocking change feed mode interoperability scoped to
EPK_RANGE_BASED_LEASE.LatestVersionand the other withAllVersionsAndDeletes, theChangeFeedProcessorwill throw anIllegalStateExceptionduring bootstrap.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines