New Data loader #43802
Open
New Data loader #43802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrm9084
requested review from
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
samsadsam
reviewed
Jan 17, 2025
...ing/cloud/appconfiguration/config/implementation/AppConfigurationSnapshotPropertySource.java
Show resolved
Hide resolved
.../com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLoader.java
Outdated
Show resolved
Hide resolved
.../com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLoader.java
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
.../com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLoader.java
Outdated
Show resolved
Hide resolved
.../spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLocationResolver.java
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
| Holder holder = new Holder(); | ||
|
|
||
| if (context.getBootstrapContext().isRegistered(AppConfigurationProperties.class)) { | ||
| properties = new AppConfigurationProperties(); |
There was a problem hiding this comment.
This is more of a question, when does this if scenario happen? Who registers the class to the bootstrap context?
samsadsam
reviewed
Jan 21, 2025
| Bindable.of(AppConfigurationProviderProperties.class), bindHandler) | ||
| .orElseGet(AppConfigurationProviderProperties::new); | ||
| } | ||
|
|
There was a problem hiding this comment.
should we add appProperties.validateAndInit(); as well?
There was a problem hiding this comment.
AppProperties are set by us and have default values. They are things like our maxRetries and stuff that the customer shouldn't be changing. I've been thinking about reworking this part of the library. I'll leave this comment open for now to track it.
samsadsam
reviewed
Jan 21, 2025
| @@ -14,8 +13,6 @@ | |||
|
|
|||
| public class TracingInfo { | |||
|
|
|||
| private boolean isDev = false; | |||
There was a problem hiding this comment.
Because of the changes it made it rather difficult to detect if it was a "dev" request. Also it was using just a convention to guess if it was dev. In all the new libraries we are not including it, so I was told it was fine to remove.
samsadsam
reviewed
Jan 21, 2025
...ing/cloud/appconfiguration/config/implementation/http/policy/BaseAppConfigurationPolicy.java
Outdated
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
...java/com/azure/spring/cloud/appconfiguration/config/implementation/feature/FeatureFlags.java
Outdated
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
.../com/azure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigDataLoader.java
Outdated
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
...ure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigBoostrapRegistrar.java
Outdated
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
...ure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigBoostrapRegistrar.java
Outdated
Show resolved
Hide resolved
samsadsam
reviewed
Jan 21, 2025
...ure/spring/cloud/appconfiguration/config/implementation/AzureAppConfigBoostrapRegistrar.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix of this, updated to main, #41539 (Had trouble merging it.)