Skip to content

Commit

Permalink
Revert "[engsys] build test assets only for browser runs (#27035)" (#…
Browse files Browse the repository at this point in the history
…27065)

This reverts commit e453c2d.

PR #27035 keeps `build;test` only for browser runs. It turns out that a
couple of packages have custom `build:test` scripts that are different
from `build`. While we can explore more on enabling `build:test` for
these few packages, this PR reverts the changes to unblock automation
builds.
  • Loading branch information
jeremymeng authored Sep 11, 2023
1 parent fd1ff8f commit 300b9bb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion eng/pipelines/templates/jobs/live.tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
- script: |
node common/scripts/install-run-rush.js build:test -t "${{parameters.PackageName}}" --verbose -p max
displayName: "Build test assets"
condition: and(succeededOrFailed(), eq(variables['TestType'], 'browser'), eq(variables['DependencyVersion'],''))
condition: and(succeededOrFailed(),eq(variables['DependencyVersion'],''))
- script: |
npm install
Expand Down
1 change: 0 additions & 1 deletion eng/pipelines/templates/steps/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ steps:
- script: |
node eng/tools/rush-runner.js build:test "${{parameters.ServiceDirectory}}" -packages "$(ArtifactPackageNames)" --verbose -p max
displayName: "Build test assets"
condition: and(succeeded(), eq(variables['TestType'], 'browser'))
- template: ../steps/use-node-test-version.yml

Expand Down

0 comments on commit 300b9bb

Please sign in to comment.