Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] - Address KeyVault feedback #13524

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Feb 2, 2021

What

  • Hide various parse identifier methods
  • Make additionalAuthenticatedData readonly

Why

These came out of the recent KV architecture review. I spoke to @sadasant and
made sure that the other tasks are not applicable to us

Callouts

The only thing I wasn't sure about is renaming EncryptOptions to EncryptParameters since I
think we already GA'd with EncryptOptions - should I add a new EncryptParameters where iv and aad
are set?

Partially resolves #13237

- Hide various parse identifier methods
- Make additionalAuthenticatedData readonly
@maorleger maorleger requested a review from heaths February 2, 2021 16:42
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Very concise.

@check-enforcer
Copy link

check-enforcer bot commented Feb 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@maorleger
Copy link
Member Author

maorleger commented Feb 2, 2021

/check-enforcer override

  • Previous commit passed all checks
  • This commit only adds a CHANGELOG entry
  • There's a known issue with check enforcer at this time

@maorleger maorleger merged commit 139774f into Azure:master Feb 2, 2021
@maorleger maorleger deleted the kv-arch-board-feedback branch February 2, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve architect board feedback for Key Vault
2 participants