[Identity] InteractiveBrowserCredential for Node now waits for the listener to start listening #15497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This comment has been minimized.
This comment has been minimized.
sadasant
changed the title
HarshaNalluru
approved these changes
Jun 1, 2021
|
Can you trigger core - ci and test-utils - ci? |
|
No pipelines are associated with this pull request. |
|
/azp run js - core - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run js - test-utils - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
@sadasant trigger the pipelines manually with the commit id. |
|
@HarshaNalluru going |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in March 30, some changes were introduced to test the case in which no browser was available for the InteractiveBrowserCredential: #14617 These changes ended up causing a weird CI bug in which sometimes, only in Windows, the Node process would get stuck when running more than the InteractiveBrowserCredential test that checked for this bug.
The solution must be about correctly bubbling up the error and cleaning up the browser we’re opening. Here’s one attempt to do so.
—-
After some testing, we found out that one solution is to wait for the listener to actually begin listening before we allow anything to collapse.