Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused eslint-disable @typescript-eslint/member-ordering in keyvault sdk #21472

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

WeiJun428
Copy link
Contributor

Fixed #7608 by removing unused /* eslint-disable @typescript-eslint/member-ordering */ from

- sdk/keyvault/keyvault-certificates/src/index.ts:8
- sdk/keyvault/keyvault-secrets/src/index.ts:3
- sdk/keyvault/keyvault-keys/src/index.ts:3

according to @jeremymeng in #7608 (comment)

@ghost ghost added KeyVault customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Apr 19, 2022
@ghost
Copy link

ghost commented Apr 19, 2022

Thank you for your contribution WeiJun428! We will review the pull request and get back to you soon.

@ghost ghost added the Impact++ This pull request was submitted by a member of the Impact++ team. label Apr 19, 2022
@WeiJun428 WeiJun428 changed the title remove unused eslint-disable @typescript-eslint/member-ordering in keyvault sdk Remove unused eslint-disable @typescript-eslint/member-ordering in keyvault sdk Apr 19, 2022
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thank you so much for the contribution!

@maorleger maorleger merged commit 7d7dee1 into Azure:main Apr 20, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Dec 8, 2022
Release app microsoft.app 2022 10 01 (Azure#21683)

* Adds base for updating Microsoft.App from version preview/2022-06-01-preview to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Add AppState and LatestReadyRevisionName (Azure#21034)

* Add new props

* add defaults

* Add swagger for client cert & CORS policy (Azure#21126)

* Fix password format of env domain for 2022-10-01 (Azure#21463)

* fix

* fix

* Remove AppState property as we decided to postpone it (Azure#21483)

* Remove AppState property as we decided to postpone it

* Fix swagger issues

* More swagger fixes

* s360 swagger correctness fixes (Azure#21472)

Co-authored-by: Nan Jiang <naji@microsoft.com>

* Add kind for managed environment (Azure#21589)

* add

* fix

* fix (Azure#21730)

* fix (Azure#21747)

Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Impact++ This pull request was submitted by a member of the Impact++ team. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable @typescript-eslint/member-ordering
2 participants