Storage/stg87 preview #25404
Merged
Storage/stg87 preview #25404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EmmaZhu
commented
Mar 29, 2023
EmmaZhu
commented
Work around the issue caused by a bug in Date when initializing from a miliseconds number.
EmmaZhu
requested review from
mikeharder,
ckairen,
deyaaeldeen,
jeremymeng,
weshaggard,
benbp,
bterlson,
xirzec,
XiaoningLiu,
vinjiang,
jiacfan,
ljian3377,
HarshaNalluru,
timovv and
joheredi
as code owners
ghost
added
Azure.Core
Event Hubs
KeyVault
Service Bus
Storage
|
API change check APIView has identified API level changes in this PR and created following API reviews. azure-storage-blob |
blueww
reviewed
Mar 29, 2023
| // For example, 13322188799999 is 2023-03-01T23:59:59.999Z, while 13322188800000 is 2023-03-01T00:00:00.000Z | ||
| // Here is to work around the bug. | ||
| if (timeNumerInMs >= BugTimeBeginningInMS) { | ||
| date.setUTCDate(date.getUTCDate() + 1); |
There was a problem hiding this comment.
Please raise a bug (or check if any exist bug) to NodeJS team, and need remove/refine this code after this bug is fixed.
There was a problem hiding this comment.
We already had a better fix for this calculation in main prior to this PR: #25072
blueww
approved these changes
Mar 29, 2023
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.