Added support for HNS permission #25675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaZhu
requested review from
bterlson,
xirzec,
jeremymeng,
XiaoningLiu,
vinjiang,
jiacfan and
ljian3377
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
blueww
reviewed
Apr 27, 2023
| @@ -62,6 +62,9 @@ describe("DataLakePathClient Node.js only", () => { | |||
| await testFileClient.create({ owner: owner }); | |||
| const result = await testFileClient.getAccessControl(); | |||
| assert.equal(result.owner, owner); | |||
|
|
|||
| const properties = await testFileClient.getProperties(); | |||
| assert.equal(properties.owner, owner); | |||
There was a problem hiding this comment.
Should we also check group/ permission are returned?
Same as below.
EmmaZhu
force-pushed
the
storage/hns_permissions
branch
from
16f078e
to
fddc0e7
Compare
blueww
approved these changes
May 5, 2023
18 tasks
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Jul 20, 2023
Port PR Azure#25675 - update blob service version to 2023-01-03 - add "appendBlock - append large block" test
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Jul 20, 2023
Port PR Azure#25675 - update blob service version to 2023-01-03 - add "appendBlock - append large block" test
jeremymeng
added a commit
that referenced
this pull request
Jul 20, 2023
Port PR #25675 - update blob service version to 2023-01-03 - add "appendBlock - append large block" test - port file-datalake source changes - port file-datalake tests and add recordings
dgetu
pushed a commit
that referenced
this pull request
Sep 6, 2023
Port PR #25675 - update blob service version to 2023-01-03 - add "appendBlock - append large block" test - port file-datalake source changes - port file-datalake tests and add recordings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for HNS permission