[Core] remove URL validations on credential scopes #25896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue: Azure#25881
|
API change check API changes are not detected in this pull request. |
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
May 19, 2023
It is possible that credential scopes are not in the format of valid URL. It is also noted in the doc that there are shorter form of scope https://learn.microsoft.com/EN-US/azure/active-directory/develop/scopes-oidc >In requests to the authorization, token or consent endpoints for the Microsoft Identity platform, if the resource identifier is omitted in the scope parameter, the resource is assumed to be Microsoft Graph. For example, `scope=User.Read` is equivalent to `https://graph.microsoft.com/User.Read`. Related issue: Azure#25881
jeremymeng
added a commit
that referenced
this pull request
May 19, 2023
) It is possible that credential scopes are not in the format of valid URL. It is also noted in the doc that there are shorter form of scope https://learn.microsoft.com/EN-US/azure/active-directory/develop/scopes-oidc >In requests to the authorization, token or consent endpoints for the Microsoft Identity platform, if the resource identifier is omitted in the scope parameter, the resource is assumed to be Microsoft Graph. For example, `scope=User.Read` is equivalent to `https://graph.microsoft.com/User.Read`. Related issue: #25881
minhanh-phan
pushed a commit
to minhanh-phan/azure-sdk-for-js
that referenced
this pull request
Jun 12, 2023
It is possible that credential scopes are not in the format of valid URL. It is also noted in the doc that there are shorter form of scope https://learn.microsoft.com/EN-US/azure/active-directory/develop/scopes-oidc >In requests to the authorization, token or consent endpoints for the Microsoft Identity platform, if the resource identifier is omitted in the scope parameter, the resource is assumed to be Microsoft Graph. For example, `scope=User.Read` is equivalent to `https://graph.microsoft.com/User.Read`. Related issue: Azure#25881
18 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Oct 12, 2023
[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview (Azure#25896) * Copying the previous version to the new version folder * Changed the swagger version to the new one * Updating the new version changes * Updated examples for the new versions * Reverting change in the existing version swagger * Fixing the semantic validation error * upgrading to v5 for common file * Adding x-ms-long-running-operation in Patch call * Updated the return code from 201 to 202 for Patch calls * Fixes for model validation * Fixing prettier check * Added patch call schema * Update the patch update sap instance property structure * Update location in examples and object description changes * Removed 200 code for Delete to fix the linter check * Removed 200 code for child instance delete calls
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Oct 12, 2023
[Microsoft.Workoads] Adding a new Api-version 2023-10-01-preview (Azure#25896) * Copying the previous version to the new version folder * Changed the swagger version to the new one * Updating the new version changes * Updated examples for the new versions * Reverting change in the existing version swagger * Fixing the semantic validation error * upgrading to v5 for common file * Adding x-ms-long-running-operation in Patch call * Updated the return code from 201 to 202 for Patch calls * Fixes for model validation * Fixing prettier check * Added patch call schema * Update the patch update sap instance property structure * Update location in examples and object description changes * Removed 200 code for Delete to fix the linter check * Removed 200 code for child instance delete calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that credential scopes are not in the format of valid URL. It is also noted in the doc that there are shorter form of scope https://learn.microsoft.com/EN-US/azure/active-directory/develop/scopes-oidc
Related issue: #25881