Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-http] export isNode from @azure/core-util #26005

Merged

Conversation

jeremymeng
Copy link
Member

core-http already depends on core-util. This PR removes core-http's isNode and export from core-util instead.

Packages impacted by this PR

@azure/core-http

Issues associated with this PR

#26003

core-http already depends on core-util. This PR removes core-http's `isNode` and
export from core-util instead.
@jeremymeng
Copy link
Member Author

/azp run js - storage-blob - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jeremymeng jeremymeng requested a review from bterlson as a code owner May 25, 2023 22:30
@jeremymeng jeremymeng merged commit 97f4ad1 into Azure:storage/stable May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants