Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-tool] await onMigrationSkipped #26070

Merged

Conversation

jeremymeng
Copy link
Member

otherwise the ongoing git commit could cause subsequent migration to fail when another git operation is invoked

Packages impacted by this PR

dev-tool

otherwise the ongoing git commit could cause subsequent migration to fail when
another git operation is invoked
Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch.

@jeremymeng jeremymeng merged commit b8a3afa into Azure:main Jun 1, 2023
@jeremymeng jeremymeng deleted the devtool/add-await-onmigrationskipped branch June 1, 2023 18:58
dgetu pushed a commit to dgetu/azure-sdk-for-js that referenced this pull request Jun 5, 2023
otherwise the ongoing git commit could cause subsequent migration to
fail when another git operation is invoked

### Packages impacted by this PR
dev-tool
minhanh-phan pushed a commit to minhanh-phan/azure-sdk-for-js that referenced this pull request Jun 12, 2023
otherwise the ongoing git commit could cause subsequent migration to
fail when another git operation is invoked

### Packages impacted by this PR
dev-tool
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Nov 2, 2023
[Hub Generated] Review request for Microsoft.DataProtection to add version preview/2023-08-01-preview (Azure#25967)

* Adds base for updating Microsoft.DataProtection from version preview/2023-06-01-preview to version 2023-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* Re-Validate API Swagger Changes

* JobCancel & Job InProgress changes

* vault tier changes aks (Azure#25972)

* Add is isPartialRP boolean to AzureBackupDiscreteRecoveryPoint and examples (Azure#25974)

* Add is ispartialrp to AzureBackupDiscreteRecoveryPoint and examples

* Fix prettier issues in examples

* Including ValidateForModifyBackupRequest Defn.

* resolved comments (Azure#26064)

* Revert IsPartialRP changes (Azure#26070)

* Using Restricted Pattern for Vault Name (Azure#26169)

* Handling Validation Errors (Azure#26186)

* removing 200 status code

* LintDiff fix - using common types error response (Azure#26187)

* whitespace handling

* Editing where clause

* Removing Where Condition

---------

Co-authored-by: Dishant Munjal <dishantmunjal@users.noreply.github.com>
Co-authored-by: chandrasekarendran <59728024+chandrasekarendran@users.noreply.github.com>
Co-authored-by: soumyapattnaik <33341338+soumyapattnaik@users.noreply.github.com>
Co-authored-by: nickpacificomsft <144935783+nickpacificomsft@users.noreply.github.com>
Co-authored-by: asmitt <62243673+asmitt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants