Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft pr for load-testing #26166

Closed
wants to merge 8 commits into from
Closed

Draft pr for load-testing #26166

wants to merge 8 commits into from

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Jun 12, 2023 •
edited
Loading

Generated from main.tsp https://github.com/MaryGao/azure-rest-api-specs/blob/loadtesting-sync-mary/specification/loadtestservice/LoadTestService/tspconfig.yaml

Breaking change

1. properties in model TestRun are removed

#26166 (comment)

2. The return type of ListMetricDimensionValues changed

#26166 (comment)

3. New supported features

Compared with last gen we introduced new features which caused codegen-side breaking and we can't avoid to mitigate. And I would suggest to respect these changes.

  • readonly/@visibility("read")
  • patch method
  • error response def moved to core
  • paged def moved to core

@MaryGao MaryGao mentioned this pull request Jun 13, 2023
Merged
@MaryGao
Copy link
Member Author

MaryGao commented Jul 4, 2023

Closed as resolved

@MaryGao MaryGao closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta left review comments

@xirzec xirzec Awaiting requested review from xirzec xirzec will be requested when the pull request is marked ready for review xirzec is a code owner

Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaryGao @catalinaperalta