[Storage] port PR #24953 from storage/stable branch #26279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
EmmaZhu,
XiaoningLiu,
vinjiang,
jiacfan and
ljian3377
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jeremymeng
added
the
Client
xirzec
reviewed
Jun 21, 2023
| @@ -268,7 +268,9 @@ export function appendToURLPath(url: string, name: string): string { | |||
| path = path ? (path.endsWith("/") ? `${path}${name}` : `${path}/${name}`) : name; | |||
| urlParsed.pathname = path; | |||
|
|
|||
| return urlParsed.toString(); | |||
| const normalizedUrl = new URL(urlParsed.toString()); | |||
There was a problem hiding this comment.
@jeremymeng the original PR was working around behavior inside URLBuilder, but since we're using URL to parse things now, do we need these changes? I'm curious if we undo this change if the test still passes.
There was a problem hiding this comment.
Yes the tests are still passing. I undid the src changes. Thanks for pointing out!
18 tasks
xirzec
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24953
URLBuilder, but switched toURL