[Azure Monitor OpenTelemetry] Add Azure Functions Correlation Hook #26313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
requested review from
ckairen,
deyaaeldeen,
jeremymeng and
JacksonWeber
as code owners
|
API change check API changes are not detected in this pull request. |
| this._functionsCoreModule = undefined; | ||
| } | ||
|
|
||
| private _addPreInvocationHook() { |
There was a problem hiding this comment.
Nothing wrong since I see this is the same way tracking context in Azure Functions in the beta works, but I'm just wondering for my understanding why we can drop the _addPostInvocationHook() method when we move away from the legacy SDK.
There was a problem hiding this comment.
Pre invocation is used to maintain correlation and Post Invocation is used to automatically generate telemetry, for auto generation of telemetry we need to have further discussions, that is why is not part of this
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Oct 25, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-09-02-preview (Azure#26313) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-08-02-preview to version 2023-09-02-preview * Updates readme * Updates API version in new specs and examples * OSSKU supports WindowsAnnual option (Azure#26120) * add VirtualMachines agent pool type (Azure#26034) * GPU Profile and Properties for AKS Windows (and Linux) GPU Feature (Azure#26072) * switch file and fix typos * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-09-02-preview/managedClusters.json Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> --------- Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> * add AgentPoolUpgradeSettings.nodeSoakDurationInMinutes (Azure#26046) * Update format for trustedaccess sourceResourceId (Azure#26123) * update readmes (Azure#26126) * Add NodeAutoProvisioning to AKS preview API (Azure#26047) * Add AIToolchainOperator to AKS preview API (Azure#26151) * Add AIToolchainOperator to AKS preview API Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com> * Remove custom name from the PR Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com> * prettier fix --------- Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com> Co-authored-by: Heba Elayoty <hebaelayoty@gmail.com> * Add ArtifactStreamingProfile and Enabled property (Azure#26144) * add ArtifactStreamingProfile to AKS API * reduce repetition * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-09-02-preview/managedClusters.json --------- Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com> * fix typo (Azure#26152) * upgrade common types (Azure#26232) * rename enum to nodeOSUpgradeChannel (Azure#26366) --------- Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com> Co-authored-by: Junjie Zhang <109257558+junjiezhang1997@users.noreply.github.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Chris Lopez <91150577+pineapplethevoyager@users.noreply.github.com> Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com> Co-authored-by: Max Horstmann <MaxHorstmann@users.noreply.github.com> Co-authored-by: Dong Liu <doliu@microsoft.com> Co-authored-by: Heba Elayoty <hebaelayoty@gmail.com> Co-authored-by: Ganeshkumar Ashokavardhanan <35557827+ganeshkumar5699@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality for @azure/monitor-opentelemetry package
Adding Azure Fn code to handle auto correlation when running in that environment