[storage] port accountName from SAS connect string support from storage/stable #26672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge/stable Port PR Azure#26159 - port source and test change for blob - update one negative test. We used to throw an error when splting an undefined `parsedUrl.pathname` in `getAccountNameFromUrl`. In core v2 we changed to use `URL` instead of `URLBuilder`. `parsedUrl.pathname` is now an empty string, an empty `accountName` is returned instead of error thrown. - duplicate source change for other storage package as we currently are doing for internal util methods.
jeremymeng
requested review from
EmmaZhu,
XiaoningLiu,
vinjiang,
jiacfan and
ljian3377
as code owners
xirzec
approved these changes
Jul 31, 2023
|
API change check API changes are not detected in this pull request. |
|
There's installatation issue from npmjs for all js pipelines recently. Going to overide as some Windows, and Linux/MacOS tests are passing |
|
/check-enforcer override |
18 tasks
dgetu
pushed a commit
that referenced
this pull request
Sep 6, 2023
…ge/stable (#26672) Port PR #26159 - port source and test change for blob - update one negative test. We used to throw an error when splting an undefined `parsedUrl.pathname` in `getAccountNameFromUrl`. In core v2 we changed to use `URL` instead of `URLBuilder`. `parsedUrl.pathname` is now an empty string, an empty `accountName` is returned instead of error thrown. - duplicate source change for other storage package as we currently are doing for internal util methods.
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Nov 16, 2023
Ericchoi/main/event hub/2024 01 01 (Azure#26672) * Adding new version 2024-01-01 with changes in Clusters.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port PR #26159
port source and test change for blob
update one negative test. We used to throw an error when splting an undefined
parsedUrl.pathnameingetAccountNameFromUrl. In core v2 we changed to useURLinstead ofURLBuilder.parsedUrl.pathnameis now an empty string, an emptyaccountNameis returned instead of error thrown.duplicate source change for other storage package as we currently are doing for internal util methods.