[dev-tool] Restore the assets only when they are present #32752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dev-tool
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
Jan 28, 2025
HarshaNalluru
commented
Jan 28, 2025
HarshaNalluru
commented
Jan 28, 2025
timovv
approved these changes
Jan 28, 2025
HarshaNalluru
added a commit
that referenced
this pull request
Jan 30, 2025
### Description This PR reverts the recent changes from [PR 32668](#32668) and [PR 32752](#32752). These changes did not fully resolve the race condition issues, as we observed continued failures, albeit with lesser frequency, even after increasing the timeouts. Increasing the timeouts further does not seem like a clean solution. Therefore, reverting these changes in this PR. ### Changes - Revert the changes introduced in PR 32668 and PR 32752. - [TO DO] A new approach to restore assets sequentially in a separate job will be implemented in a follow-up PR. ### Related Issue Issues observed at the current state of restoring assets: [Issue 32805](#32805)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue in PR #32668 where the existence of the
assets.jsonfile was not checked before pulling the recordings. This PR adds a check for the file's existence.Problem 2
Introduced retries for the 'restore' command to mitigate EBUSY errors, which occur due to resource locking by simultaneous pipeline processes.
Fixes
This change fixes the failing pipelines, such as the
monitor-opentelemetry-exporterpackage.Pipeline Results