Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ObjectSerializer implementation to Azure.Core #13619

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Jul 21, 2020

Fixes #13320

Part of Azure/azure-sdk#1578

To quote @tg-msft

We’re introducing a Bring Your Own Serializer model because there a lot of customers who wont come to Track 2 without it. ObjectSerializer is the base abstraction. We’re shipping JsonObjectSerializer : ObjectSerializer to wrap using System.Text.Json. As a customer you’ll still use all the System.Text.Json attributes, naming policies, options, documentation, etc., for your type T. You’ll just tell our client libraries which serializer you’re using via clientOptions.Serializer = new JsonObjectSerializer(new System.Text.Json.JsonSerializerOptions(...)) and we’ll use it for all your custom model types in our clients. You can see more example usage in the tests.

@ghost ghost added the Azure.Core label Jul 21, 2020
@pakrym pakrym marked this pull request as ready for review July 23, 2020 19:54
@pakrym
Copy link
Contributor Author

pakrym commented Jul 23, 2020

/check-enforcer override

@pakrym pakrym merged commit 8816bbf into Azure:master Jul 23, 2020
@pakrym pakrym deleted the pakrym/object-serializer branch July 23, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ObjectSerializer to Azure.Core
2 participants