Update AutoRest C# version #15469
Merged
Update AutoRest C# version #15469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
requested review from
ahamad-MS,
AlexGhiondea,
allenjzhang,
annelo-msft,
arv100kri,
bleroy,
bquantump,
brjohnstmsft,
chidozieononiwu,
cijothomas,
danieljurek,
DominikMe,
heaths,
kinelski,
Kishp01,
m-nash,
maririos,
markcowl,
mitchdenny,
nisha-bhatia,
rajkumar-rangaraj,
reyang,
RezaJooyandeh,
schaabs,
tg-msft,
TimothyMothra,
weshaggard,
YalinLi0312 and
a team
as code owners
ShivangiReja
requested review from
pakrym,
christothes,
maririos,
chidozieononiwu,
KrzysztofCwalina and
schaabs
and removed request for
reyang,
YalinLi0312,
annelo-msft,
Kishp01,
TimothyMothra,
chidozieononiwu,
bquantump,
m-nash,
nisha-bhatia,
weshaggard,
pakrym,
maririos,
christothes,
KrzysztofCwalina and
schaabs
pakrym
reviewed
Sep 29, 2020
| @@ -5,6 +5,6 @@ | |||
|
|
|||
| namespace Azure.Communication.Chat | |||
| { | |||
| [CodeGenClient("ServiceRestClient")] | |||
| [CodeGenClient("AzureCommunicationChatServiceRestClient")] | |||
There was a problem hiding this comment.
I am guessing it is removing the whitespaces in the title.
Eg: "Azure Communication Chat Service" is becoming "AzureCommunicationChatServiceRestClient". In which case, I wonder if we should set the titles differently.
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/communication/data-plane/Microsoft.CommunicationServicesChat/preview/2020-09-21-preview2/communicationserviceschat.json#L4
There was a problem hiding this comment.
@pakrym Yes, it is coming from the title. Please let me know if we want to set a different title for this.
pakrym
reviewed
Sep 29, 2020
sdk/testcommon/Azure.Management.Network.2020_04/src/Generated/NetworkManagementClient.cs
Outdated
Show resolved
Hide resolved
…nto pr/azure-sdk/15469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AutoRest C# version to 1.0.0-alpha.20200925.1