Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap msal exceptions #20371

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Conversation

christothes
Copy link
Member

Fixes #20218

@christothes christothes requested a review from schaabs as a code owner April 13, 2021 23:06
@ghost ghost added the Azure.Identity label Apr 13, 2021
@@ -38,7 +38,8 @@ public class VisualStudioCodeCredential : TokenCredential
/// <param name="options">Options for configuring the credential.</param>
public VisualStudioCodeCredential(VisualStudioCodeCredentialOptions options) : this(options, default, default, default, default) { }

internal VisualStudioCodeCredential(VisualStudioCodeCredentialOptions options, CredentialPipeline pipeline, MsalPublicClient client, IFileSystemService fileSystem, IVisualStudioCodeAdapter vscAdapter)
internal VisualStudioCodeCredential(VisualStudioCodeCredentialOptions options, CredentialPipeline pipeline, MsalPublicClient client, IFileSystemService fileSystem,
IVisualStudioCodeAdapter vscAdapter)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this file only contains formatting changes. Did you mean to include in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - I've been experimenting with IDE settings, and the format was doing unexpected things :)

@christothes christothes merged commit 8bffc26 into Azure:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants