BatchAccountIdentity constructor breaking change #25043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paterasMSFT
requested review from
archerzz,
ArcturusZhang,
ArthurMa1978,
bgklein,
chidozieononiwu,
danieljurek,
dpwatrous,
fengzhou-msft,
m-nash,
weshaggard,
wiboris and
Yao725
as code owners
ghost
added
the
11 tasks
wiboris
reviewed
Nov 1, 2021
wiboris
approved these changes
Nov 1, 2021
dpwatrous
requested changes
Nov 1, 2021
...h/Microsoft.Azure.Batch.Conventions.Files/src/Microsoft.Azure.Batch.Conventions.Files.csproj
Outdated
Show resolved
Hide resolved
sdk/batch/Microsoft.Azure.Batch.FileStaging/src/Microsoft.Azure.Batch.FileStaging.csproj
Outdated
Show resolved
Hide resolved
paterasMSFT
force-pushed
the
mipatera/newbatchaccountidentityfix
branch
3 times, most recently
from
9e5a0c5 to
623e8cf
Compare
dpwatrous
approved these changes
Nov 2, 2021
paterasMSFT
force-pushed
the
mipatera/newbatchaccountidentityfix
branch
from
623e8cf to
98c47a2
Compare
Changed test location for CloudService test. Update changelog and version. Added more legacy constructors. Fixed constructor and test Add another 2 argument constructor for BatchAccountIdentity Mark legacy identity class and related constructor as obsolete Mark legacy identity class and related constructor as obsolete Added nuget config to fix package build order issue. Revert "Added nuget config to fix package build order issue." This reverts commit b59ade3. Updated batch version Revert "Updated batch version" This reverts commit 86a050d. Fixed changelog date Fixed changelog
Session records Updated session recordings. Updated location filter value to fix scenario test.
Updated package version Updated version Fixed versioning Fixed version Reverted to v4.2, will address in pending DataPlane update.
Revert "Set RestorePackagePath" This reverts commit f69ea24ed26d600c35d2df438804a8e7f121b731. Removed GeneratePackageOnBuild This resolved a packing issue. See [here](dotnet/sdk#10335) for more information.
paterasMSFT
force-pushed
the
mipatera/newbatchaccountidentityfix
branch
from
98c47a2 to
90592e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous release introduced a breaking type ambiguity to BatchAccountIdentity's constructor. This PR corrects that.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines