Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AzureMonitorExporter] update OpenTelemetry dependencies to v1.5.0 #36859

Merged
merged 13 commits into from
Jun 16, 2023
Merged

[AzureMonitorExporter] update OpenTelemetry dependencies to v1.5.0 #36859

merged 13 commits into from
Jun 16, 2023

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Jun 6, 2023 •
edited
Loading

Changes

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Jun 6, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@TimothyMothra TimothyMothra force-pushed the tilee/updateOtel_1.5.0 branch from f84867b to 5b738d8 Compare June 6, 2023 22:42
@vishweshbankwar
Copy link
Contributor

@TimothyMothra It would be good to validate the changes against otlp exporter changes that was done in the pr you referenced.

@TimothyMothra
Copy link
Contributor Author

@TimothyMothra It would be good to validate the changes against otlp exporter changes that was done in the pr you referenced.

I don't see any of the Exporters in the otel repo checking the ParseStateValues

@TimothyMothra
Copy link
Contributor Author

TimothyMothra commented Jun 14, 2023 •
edited
Loading

TODO: Need to lock to SDK v1.5.x or lower because of coming breaking changes.

Edit: nevermind

@cijothomas
Copy link
Contributor

@TimothyMothra It would be good to validate the changes against otlp exporter changes that was done in the pr you referenced.

I don't see any of the Exporters in the otel repo checking the ParseStateValues

There are no breaking changes. So even if this exporter do nothing, everything would work as before. (Ofcourse there will be warning about using obsolete things, but if you suppress it, then there is no need of any change here.)

@cijothomas
Copy link
Contributor

TODO: Need to lock to SDK v1.5.x or lower because of coming breaking changes.

Where is breaking change in Otel sdk?

@TimothyMothra
Copy link
Contributor Author

TimothyMothra commented Jun 14, 2023 •
edited
Loading

TODO: Need to lock to SDK v1.5.x or lower because of coming breaking changes.

Where is breaking change in Otel sdk?

Breaking changes are coming in the Instrumentation Libraries & Http Semantic Conventions.
We want to snap the Exporter to a known version of the base SDK.

Edit: nevermind. abandoned this

rajkumar-rangaraj
rajkumar-rangaraj approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TimothyMothra TimothyMothra merged commit e49bccd into main Jun 16, 2023
@TimothyMothra TimothyMothra deleted the tilee/updateOtel_1.5.0 branch June 16, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@hallipr hallipr Awaiting requested review from hallipr

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

@cijothomas cijothomas Awaiting requested review from cijothomas

@reyang reyang Awaiting requested review from reyang

Assignees
No one assigned
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimothyMothra @azure-sdk @vishweshbankwar @cijothomas @rajkumar-rangaraj