Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing target base scale instance concurrency for queues #41158

Closed
wants to merge 1 commit into from

Conversation

alrod
Copy link
Member

@alrod alrod commented Jan 11, 2024

Currently Azure Queues, we’re using BatchSize as per instance concurrency. The actual per instance concurrency is given by the formula C = NewBatchThreshhold + BatchSize. For example, when only BatchSize is set to 16 (the maximum value), the instance concurrency is 24. However if both BatchSize=16 and NewBatchThreshold=200, then instance concurrency is 216. Given this, current TBS model is overscale.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jan 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link

Hi @alrod. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Mar 15, 2024
@amnguye
Copy link
Member

amnguye commented Mar 18, 2024

Hey @alrod Sorry this PR fell through the cracks. Let me rerun CI and see if things will just pass.

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Mar 18, 2024
Copy link

Hi @alrod. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 24, 2024
Copy link

Hi @alrod. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this May 31, 2024
@alrod alrod reopened this Jun 15, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jun 15, 2024
@alrod
Copy link
Member Author

alrod commented Jun 17, 2024

/azp run net - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@amnguye
Copy link
Member

amnguye commented Jun 18, 2024

/azp run net - storage - ci

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@amnguye
Copy link
Member

amnguye commented Jun 18, 2024

Looks like pipeline bot is being strict here, because the branch name doesn't start with "feature/*", I wonder if there's a way around it.

@amnguye
Copy link
Member

amnguye commented Jul 22, 2024

Closed because we merged this PR
#44661

@amnguye amnguye closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants