Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docs variables to globals.yml instead of needlessly passing them around #47188

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add Docs variables to globals.yml instead of needlessly passing them around #47188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions eng/pipelines/docindex.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
name: $(LINUXPOOL)
variables:
DocRepoLocation: $(Pipeline.Workspace)/docs
DocRepoOwner: Azure
DocRepoName: azure-docs-sdk-dotnet
steps:
# Checkout the eng folder from the SDK repo
- template: /eng/common/pipelines/templates/steps/sparse-checkout.yml
Expand Down
10 changes: 4 additions & 6 deletions eng/pipelines/templates/stages/archetype-net-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ parameters:
ArtifactName: 'not-specified'
# Publish to https://dev.azure.com/azure-sdk/public/_packaging?_a=feed&feed=azure-sdk-for-net
DevOpsFeedId: '29ec6040-b234-4e31-b139-33dc4287b756/fa8c16a3-dbe0-4de2-a297-03065ec1ba3f'
TargetDocRepoOwner: 'not-specified'
TargetDocRepoName: 'not-specified'


stages:
Expand Down Expand Up @@ -208,8 +206,8 @@ stages:
PackageInfoLocations:
- $(Pipeline.Workspace)/${{parameters.ArtifactName}}/PackageInfo/${{artifact.name}}.json
WorkingDirectory: $(System.DefaultWorkingDirectory)
TargetDocRepoOwner: ${{parameters.TargetDocRepoOwner}}
TargetDocRepoName: ${{parameters.TargetDocRepoName}}
TargetDocRepoOwner: $(DocRepoOwner)
TargetDocRepoName: $(DocRepoName)
Language: 'dotnet'
SparseCheckoutPaths:
- /api/overview/azure/
Expand Down Expand Up @@ -342,8 +340,8 @@ stages:
- ${{if ne(artifact.skipPublishDocMs, 'true')}}:
- $(Pipeline.Workspace)/${{parameters.ArtifactName}}/PackageInfo/${{artifact.name}}.json
WorkingDirectory: $(System.DefaultWorkingDirectory)
TargetDocRepoOwner: ${{parameters.TargetDocRepoOwner}}
TargetDocRepoName: ${{parameters.TargetDocRepoName}}
TargetDocRepoOwner: $(DocRepoOwner)
TargetDocRepoName: $(DocRepoName)
Language: 'dotnet'
DailyDocsBuild: true
SparseCheckoutPaths:
Expand Down
8 changes: 0 additions & 8 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ parameters:
- name: ServiceDirectory
type: string
default: not-specified
- name: TargetDocRepoOwner
type: string
default: Azure
- name: TargetDocRepoName
type: string
default: azure-docs-sdk-dotnet
- name: BuildSnippets
type: boolean
default: true
Expand Down Expand Up @@ -111,6 +105,4 @@ extends:
${{ if eq(parameters.ServiceDirectory, 'template') }}:
TestPipeline: true
ArtifactName: packages
TargetDocRepoOwner: ${{ parameters.TargetDocRepoOwner }}
TargetDocRepoName: ${{ parameters.TargetDocRepoName }}

4 changes: 4 additions & 0 deletions eng/pipelines/templates/variables/globals.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@ variables:
# Define optional AdditionalTestFilters via pipeline runtime variables or matrix config variables
# See https://docs.microsoft.com/dotnet/core/testing/selective-unit-tests?pivots=nunit
AdditionalTestFilters: "Placeholder!=DefaultIgnoreMe"

# Docs publishing variables for repo/owner
DocRepoOwner: 'Azure'
DocRepoName: 'azure-docs-sdk-dotnet'