Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade API spec version to 2023-06-01 #47236

Closed

Conversation

dubiety
Copy link
Member

@dubiety dubiety commented Nov 19, 2024

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@dubiety dubiety requested a review from live1206 November 19, 2024 07:55
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Nov 19, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Maps

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code is not up to date.
You may need to rebase on the latest main,
run 'eng\scripts\Update-Snippets.ps1' if you modified sample snippets or other *.md files (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#updating-sample-snippets),
run 'eng\scripts\Export-API.ps1' if you changed public APIs (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#public-api-additions).
run 'dotnet build /t:GenerateCode' to update the generated code and samples.

To reproduce this error locally, run 'eng\scripts\CodeChecks.ps1 -ServiceDirectory maps'.

@dubiety
Copy link
Member Author

dubiety commented Nov 19, 2024

Hi @archerzz , due to some technical issue, I've created another PR (#47239) and address your comments.

I've update the naming for Encryption, InfrastructureEncryption, and IdentityType with prepend RP name. Please take a look at the new PR. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants