Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't pass force_refresh through get_token to MSAL's acquire_token_silent_with_error #17825

Closed
jiasli opened this issue Apr 6, 2021 · 1 comment
Closed

Can't pass force_refresh through get_token to MSAL's acquire_token_silent_with_error #17825

jiasli opened this issue Apr 6, 2021 · 1 comment
Assignees
@chlowell
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@jiasli
Copy link
Member

jiasli commented Apr 6, 2021

Symptom

Due to the removal of kwargs when calling acquire_token_silent_with_error (#16323 (comment)), it is now impossible to pass force_refresh through get_token to MSAL's acquire_token_silent_with_error.

Impact
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 6, 2021
@chlowell chlowell self-assigned this Apr 6, 2021
@chlowell chlowell added Azure.Identity feature-request This issue requires a new behavior in the product in order be resolved. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 6, 2021
@lmazuel lmazuel added the Client This issue points to a problem in the data-plane of the library. label May 7, 2021
@chlowell
Copy link
Member

I'm closing this because we don't support passing arguments to MSAL, and this particular scenario is moot because the proposed solution wasn't implemented. More generally, we haven't added a force_refresh argument to get_token because we can't promise a new token. For example, managed identity endpoints typically maintain a token cache but not all endpoints provide a way to bypass that cache.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 2, 2022
CodeGen from PR 17825 in Azure/azure-rest-api-specs
45edfcf 
adding activeDirectoryConnectors resource type (2022-03-01-preview) (Azure#17825)

* Adds base for updating Microsoft.AzureArcData from version stable/2021-11-01 to version 2022-03-01-preview

* Updates readme

* Updates API version in new specs and examples

* adding activeDirectoryConnectors resource type

* setting integer format

* added example files

* ran prettier check

* fixing model errors

* removing tags

* removing patch

* adding array identifier

* add array identifier

* prettier fix

* fixing linter errors and warnings

* fixing linting errors

* fixing more lint warnings

* reverted changes to DC method names

* updating operations list

* merging ESU updates to swagger

* changed description for keytab file

* adding terms to custom words

* simplifying AD domain controller model

* adding postgres instances

* removing duplicated property BasicLogin

* fixing syntax error

* fixing linting warnings
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chlowell chlowell

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lmazuel @jiasli @chlowell