Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication]: Updated communication connection strings to be consistent across packages and languages #18519

Merged
merged 2 commits into from
May 6, 2021

Conversation

lsundaralingam
Copy link
Member

@lsundaralingam lsundaralingam commented May 5, 2021

  • All samples will use COMMUNICATION_SAMPLES_CONNECTION_STRING
  • Chat and Identity tests will use COMMUNICATION_LIVETEST_DYNAMIC_CONNECTION_STRING
  • Phone Numbers and SMS tests will use COMMUNICATION_LIVETEST_STATIC_CONNECTION_STRING

@ghost ghost added the Communication label May 5, 2021
@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam changed the title [Communication]: Updated communication connection strings in live tests [Communication]: Updated communication connection strings to be consistent across packages and languages May 6, 2021
@lsundaralingam
Copy link
Member Author

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam marked this pull request as ready for review May 6, 2021 17:40
Copy link
Contributor

@jbeauregardb jbeauregardb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Lakshman! Thank you

@lsundaralingam lsundaralingam merged commit 921940a into Azure:master May 6, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 7, 2021
…into azure_purview_scanning

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  [purview] add catalog client (Azure#17788)
  Add spellcheck for modified files (Azure#18496)
  [Container Registry] Update API for Beta 2 (Azure#18392)
  First version of Confidential Ledger Python SDK (Azure#17951)
  [llc] add quickstart (Azure#18537)
  [Storage][Fix]Copy source is redirecting (Azure#18577)
  [Tables] pre-release script (Azure#18505)
  Update changelogs (Azure#18575)
  [formrecognizer] Adding to_dict() on custom models (Azure#18402)
  Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509)
  Extend Check Enforcer timeout (Azure#18526)
  Core raw streaming (Azure#17920)
  hide secrets in mgmt sdk (Azure#18535)
  add filter samples for list methods (Azure#18480)
  Revert changes to SetDevVersion. (Azure#18555)
  add support for filtering/paging/sorting options for "list_**" methods (Azure#18302)
  [Tables] Misc client updates (Azure#18462)
  [EventHub&ServiceBus] Prepare for release (Azure#18527)
  [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519)
  [AppConfig] Fixing samples (Azure#18542)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 7, 2021
…into agrifood_nspkg

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  [purview] add catalog client (Azure#17788)
  Add spellcheck for modified files (Azure#18496)
  [Container Registry] Update API for Beta 2 (Azure#18392)
  First version of Confidential Ledger Python SDK (Azure#17951)
  [llc] add quickstart (Azure#18537)
  [Storage][Fix]Copy source is redirecting (Azure#18577)
  [Tables] pre-release script (Azure#18505)
  Update changelogs (Azure#18575)
  [formrecognizer] Adding to_dict() on custom models (Azure#18402)
  Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509)
  Extend Check Enforcer timeout (Azure#18526)
  Core raw streaming (Azure#17920)
  hide secrets in mgmt sdk (Azure#18535)
  add filter samples for list methods (Azure#18480)
  Revert changes to SetDevVersion. (Azure#18555)
  add support for filtering/paging/sorting options for "list_**" methods (Azure#18302)
  [Tables] Misc client updates (Azure#18462)
  [EventHub&ServiceBus] Prepare for release (Azure#18527)
  [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519)
  [AppConfig] Fixing samples (Azure#18542)
  ...
@lsundaralingam lsundaralingam deleted the updateEnv branch May 11, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants