Add sender_display_name in SendTypingNotification Operation #19760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuChen-Microsoft
requested review from
ankitarorabit,
memontic-ms and
a team
as code owners
ghost
added
the
annatisch
reviewed
Jul 13, 2021
| @@ -242,6 +243,8 @@ async def send_typing_notification( | |||
| ) -> None: | |||
There was a problem hiding this comment.
If you wanted, you could use the * syntax:
async def send_typing_notification(
self,
*,
sender_display_name: Optional[str] = None,
**kwargs
) -> None:There was a problem hiding this comment.
Is this the prefer format in async methods?
There was a problem hiding this comment.
Usually, yes - it works better with intellisense.
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_thread_client.py
Show resolved
Hide resolved
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Added | |||
| - Added support to add `metadata` for `message` | |||
| - Added support to add `sender_display_name` for `SendTypingNotification` | |||
There was a problem hiding this comment.
SendTypingNotification -> ChatThreadClient.send_typing_notification
|
/azp run python - azure-communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Jul 13, 2021
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.