Sync eng/common directory with azure-sdk-tools for PR 1912 #20340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.
Worked without terminating when run locally, but failed on the first error in the AzDO agent.
More idiomatic for passing ScriptBlocks to jobs.
azure-sdk
requested review from
danieljurek,
scbedd and
weshaggard
as code owners
azure-sdk
added
Central-EngSys
heaths
approved these changes
Aug 18, 2021
iscai-msft
added a commit
that referenced
this pull request
Aug 23, 2021
…into header_tuples * 'main' of https://github.com/Azure/azure-sdk-for-python: (104 commits) [Key Vault] Add 7.3-preview support for administration (#20364) Fix Monitor opentelemetry exporter readme issues (#19038) More Renaming in query (#20303) Update CODEOWNERS (#20366) [ServiceBus] update migration guide with message count info (#20360) [rest] change text from a property to a method (#20290) Handle value types for results (#20358) Remove old unused update changelog script (#20357) bump node version (#20353) [AutoRelease] t2-web-2021-08-03-73015 (#20053) Fix query batch processing (#20345) Sync eng/common directory with azure-sdk-tools for PR 1912 (#20340) Increment version for schemaregistry releases (#20326) [SchemaRegistry] prepare avro for release (#20321) Update CHANGELOG.md (#20334) Update main.py (#20332) Removing C:\Git\azure-sdk-tools\eng\common\scripts\FilterPoliCheckResults.ps1 as it was no longer used (#20325) Suppress CredScan warning for test proxy devcert (#20324) [SchemaRegistry] update samples readme (#20323) [Test Proxy] Add RecordedByProxy decorator and AzureRecordedTestCase (#20138) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 23, 2021
…into have_pipelines_support_rest * 'main' of https://github.com/Azure/azure-sdk-for-python: (27 commits) Document Pod Identity's special use of client_id (Azure#20377) [rest] use azure json encoder for json input bodies (Azure#20361) CertificateCredential supports PKCS12 certs (Azure#16384) Bug fix for pipeline downloading incorrect package ver (Azure#20294) Update metadata values (Azure#20365) [Key Vault] Add 7.3-preview support for administration (Azure#20364) Fix Monitor opentelemetry exporter readme issues (Azure#19038) More Renaming in query (Azure#20303) Update CODEOWNERS (Azure#20366) [ServiceBus] update migration guide with message count info (Azure#20360) [rest] change text from a property to a method (Azure#20290) Handle value types for results (Azure#20358) Remove old unused update changelog script (Azure#20357) bump node version (Azure#20353) [AutoRelease] t2-web-2021-08-03-73015 (Azure#20053) Fix query batch processing (Azure#20345) Sync eng/common directory with azure-sdk-tools for PR 1912 (Azure#20340) Increment version for schemaregistry releases (Azure#20326) [SchemaRegistry] prepare avro for release (Azure#20321) Update CHANGELOG.md (Azure#20334) ...
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Attempt to purge all vaults, managed HSMs Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days. * Add timeout and more logging * Pass required -Resource * Fix log message * Ensure the $Resource is correctly captured Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected. * Add -ErrorAction to Receive-Job Worked without terminating when run locally, but failed on the first error in the AzDO agent. * Use $using:r instead of creating ScriptBlock More idiomatic for passing ScriptBlocks to jobs. * Resolve PR feedback * Change default DeleteAfterHours to 120 Resolves #1917 * Use the Az cmdlets built-in -AsJob Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1912 See eng/common workflow