Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Add x-ms-creation-time to response on download #28745

Conversation

vincenttran-msft
Copy link
Member

This PR simply generates on the new swagger that will allow for x-ms-creation-time to be properly parsed from the response headers and populate the properties.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Feb 10, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob

Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm hesitant for us to take all the additional changes from the updated autorest version directly into main with the upcoming GA release. It may be better for us to try and re-generate with whichever version of autorest was previously used to limit the changes to only the new stuff for creation-time. You can force an autorest version when generating the code but we'll just need to figure out which version.

Also, maybe we should add a test? Or find a test to add a check for the property to?

@vincenttran-msft
Copy link
Member Author

Hmm I'm hesitant for us to take all the additional changes from the updated autorest version directly into main with the upcoming GA release. It may be better for us to try and re-generate with whichever version of autorest was previously used to limit the changes to only the new stuff for creation-time. You can force an autorest version when generating the code but we'll just need to figure out which version.

Also, maybe we should add a test? Or find a test to add a check for the property to?

Good point. I was not aware that the updated autorest version also got slapped in there, but I definitely agree we should drop the autorest version to only introduce the intended change (x-ms-creation-time header on response). Let's circle back to this later 😄

@vincenttran-msft vincenttran-msft merged commit 8dc6cc8 into Azure:main Feb 17, 2023
@vincenttran-msft vincenttran-msft deleted the vincenttran/test_creation_time_swagger branch February 17, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants