[Identity] Documentation updates #32691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
pvaneck
force-pushed
the
identity-docs-nov
branch
2 times, most recently
from
47ebc09 to
d334f80
Compare
pvaneck
requested review from
joshfree,
billwert,
ahsonkhan,
KarishmaGhiya,
chlowell and
mpodwysocki
pvaneck
force-pushed
the
identity-docs-nov
branch
from
d334f80 to
1340ab4
Compare
joshfree
approved these changes
Oct 25, 2023
billwert
reviewed
Oct 25, 2023
pvaneck
commented
Oct 25, 2023
scottaddie
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Nit: Change the https://azure.microsoft.com/free/ links to https://azure.microsoft.com/free/python.
This fleshes out WAM/broker related documentation for the identity libraries. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-docs-nov
branch
from
1340ab4 to
2097a1a
Compare
- Added MSA passthrough section - Removed reference to UsernamePasswordBrokerCredential - Updated links and headings Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-docs-nov
branch
from
2097a1a to
40f8172
Compare
|
Thanks, all, for the feedback. Will merge this as I want to get the azure-identity readme doc updated for the Python GA tomorrow. I will add a tidbit about the redirect URI configuration in the broker README in a follow-up PR. |
|
|
||
|  | ||
|
|
||
| Since azure-identity 1.15.0b1, you can set `enable_msa_passthrough`` to `True`, and MSA outlook.com accounts that are logged in to Windows are automatically listed: | ||
| When constructing the credential, you can set the `enable_msa_passthrough` keyword argument to `True`, and MSA outlook.com accounts that are logged in to Windows are automatically listed: |
There was a problem hiding this comment.
Should we add in error codes and error names for NativeAuthError so users will know it's from the broker?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fleshes out WAM/broker related documentation for the identity libraries.
Ref: #30163