Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use named logger with the AzureMonitorLogExporter instead of root logger #35771

Merged
merged 1 commit into from
May 28, 2024
Merged

docs: use named logger with the AzureMonitorLogExporter instead of root logger #35771

merged 1 commit into from
May 28, 2024

Conversation

johschmidt42
Copy link
Contributor

@johschmidt42 johschmidt42 commented May 26, 2024

Description

The example for the AzureMonitorLogExporter: Export Hello World Log fails if the LoggingHandler is added to the root logger because of recursive behaviour. Therefore it is recommended to add the LoggingHandler to a named logger instead or silence the azure-core sdk as discussed in #34787.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter labels May 26, 2024
Copy link

Thank you for your contribution @johschmidt42! We will review the pull request and get back to you soon.

@johschmidt42
Copy link
Contributor Author

@johschmidt42 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@lzchen
Copy link
Member

lzchen commented May 28, 2024

@johschmidt42

Thanks for the contribution!

@lzchen lzchen merged commit a8ed00e into Azure:main May 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants