This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix for the faraday issue #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarangan12 Could you please make sure CI passes or does it require this fix? |
vishrutshah
suggested changes
Apr 4, 2017
There was a problem hiding this comment.
@sarangan12 Could you please make sure CI passes or does it require this fix?
|
@vishrutshah my bad.... done now |
vishrutshah
approved these changes
Apr 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to::
Made the change locally and tested with our rspec and confirmed none of our tests are breaking. Will send the release related changes in a separate PR.
@devigned @vishrutshah @veronicagg @salameer Please review and approve.