Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrally manage all dependencies as workspace dependencies #1591

Open
1 of 3 tasks
heaths opened this issue Jan 24, 2024 · 1 comment
Open
1 of 3 tasks

Centrally manage all dependencies as workspace dependencies #1591

heaths opened this issue Jan 24, 2024 · 1 comment
Assignees
Labels
Azure.Core The azure_core crate

Comments

@heaths
Copy link
Member

heaths commented Jan 24, 2024

  • Move all HLC dependencies to root Cargo.toml in [workspace.dependencies].
  • Update code generator to use inherited dependencies.
  • Add validation to make sure new package-level dependencies aren't defined, possibly as a clippy lint.
@heaths heaths converted this from a draft issue Jan 24, 2024
@heaths heaths self-assigned this Jan 24, 2024
@heaths
Copy link
Member Author

heaths commented Feb 2, 2024

Given a healthy discussion within the Rust community, we may need to write validation as a standalone executable we can run in pipelines. Simplistically, it just needs to deserialize Cargo.toml (use cargo_util_schemas with serde) for individual crates and make sure all dependencies (see list below) use workspace = true.

  • dependencies
  • dev-dependencies
  • build-dependencies
  • regex: ^target\..*\.(dev-|build-)?dependencies$

heaths added a commit to heaths/azure-sdk-for-rust that referenced this issue Feb 27, 2024
Partial, short-term solution for Azure#1591. Still need to hook it into the
build after we centralize all dependencies.
heaths added a commit that referenced this issue Feb 27, 2024
* Add Rust script to verify centralized dependencies

Partial, short-term solution for #1591. Still need to hook it into the
build after we centralize all dependencies.

* Check all dependencies
@RickWinter RickWinter added the Azure.Core The azure_core crate label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core The azure_core crate
Projects
Status: No status
Development

No branches or pull requests

2 participants