-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Enforce API approval status for GA and include SDK type in package pr… (
#1345) Changes: - Include SDK type in package properties - Dump package properties to json file before version is changed - Add check in API review creation step to enforce API view approval for GA verion data plane packages.
- Loading branch information
1 parent
dfa90c3
commit cc8a11f
Showing
4 changed files
with
79 additions
and
6 deletions.
There are no files selected for viewing
14 changes: 13 additions & 1 deletion
14
eng/common/pipelines/templates/steps/daily-dev-build-variable.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
[CmdletBinding()] | ||
Param ( | ||
[Parameter(Mandatory=$True)] | ||
[string] $serviceDirectory, | ||
[Parameter(Mandatory=$True)] | ||
[string] $outDirectory | ||
) | ||
|
||
. (Join-Path $PSScriptRoot common.ps1) | ||
$allPackageProperties = Get-AllPkgProperties $serviceDirectory | ||
if ($allPackageProperties) | ||
{ | ||
New-Item -ItemType Directory -Force -Path $outDirectory | ||
foreach($pkg in $allPackageProperties) | ||
{ | ||
if ($pkg.IsNewSDK) | ||
{ | ||
Write-Host "Package Name: $($pkg.Name)" | ||
Write-Host "Package Version: $($pkg.Version)" | ||
Write-Host "Package SDK Type: $($pkg.SdkType)" | ||
$outputPath = Join-Path -Path $outDirectory ($pkg.Name + ".json") | ||
$outputObject = $pkg | ConvertTo-Json | ||
Set-Content -Path $outputPath -Value $outputObject | ||
} | ||
} | ||
|
||
Get-ChildItem -Path $outDirectory | ||
} | ||
else | ||
{ | ||
Write-Error "Package properties are not available for service directory $($serviceDirectory)" | ||
exit 1 | ||
} | ||
|