Default the repo parameters to the repo being built #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2020
This was referenced Sep 15, 2020
|
Azure/azure-sdk-for-java#15223 is the link for the associated follow-up changes in the Java repo to remove the hard-coded names. |
|
PR 1000! Congrats, you win a free... emoji?! 🎉 |
ghost
pushed a commit
to Azure/azure-sdk-for-java
that referenced
this pull request
Oct 12, 2020
Removes the hard-code repo paths and uses the default repo we are building from to populate those parameters. This change depends on Azure/azure-sdk-tools#1000 and cannot merge before it.
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an effort to make our templates work in other repos, like our private repos, we have a number of places were we need to remove the hard-coded repo names as part of that I've updated our common templates to default to the repo being built.
Once this goes in we will also need to make other changes in the language repo's to stop passing in hard-coded paths for the repo, see https://github.com/Azure/azure-sdk-for-java-pr/commit/d69194e6990f45ef2994fa6d4ade1dabc02031fc for my template tests in the java repo.