-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we always log in as app or provisioner #1175
Conversation
This also adds previously-required parameters back into @PSBoundParameters to pass down to pre- and post-scripts.
The following pipelines have been queued for testing: |
|
||
Log "Created service principal '$TestApplicationId'" | ||
Log "Created service principal '$TestApplicationId'" | ||
} | ||
|
||
if (!$ProvisionerApplicationId) { | ||
$ProvisionerApplicationId = $TestApplicationId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update PSBoundParameters here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And ProvisionerApplicationSecret and TenantId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestApplicationOid is also updated later in the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BaseName is updated later as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as ResourceGroupName
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This also adds previously-required parameters back into @PSBoundParameters to pass down to pre- and post-scripts.
This also adds previously-required parameters back into
@PSBoundParameters to pass down to pre- and post-scripts.