Add api approval history #8024
Merged
Add api approval history #8024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have screenshots of the changes so we can see how it looks? |
|
I do! Second screen shot is actual date/time displayed on hover. |
Thank you! couple questions:
|
|
Thanks for the feedback!
|
src/dotnet/APIView/APIViewWeb/Client/css/shared/bootstraps-overrides.scss
Outdated
Show resolved
Hide resolved
chidozieononiwu
requested changes
Apr 20, 2024
WhitShake
force-pushed
the
addAPIApprovalHistory
branch
from
cbe63cd to
500e293
Compare
chidozieononiwu
approved these changes
Apr 25, 2024
maririos
reviewed
Apr 25, 2024
maririos
approved these changes
Apr 25, 2024
scbedd
added a commit
to scbedd/azure-sdk-tools
that referenced
this pull request
Apr 26, 2024
update to version with removable sanitizers refencing newest version of the proxy with correct Location header and redaction of uri hostnames update the version of the proxy update the proxy version to one with tenantid Add api approval history (Azure#8024) * Approval history functional but unstyled * Icons added to history * Icons and history styled, comment display added but need to add comment to test * Changed Created field * Reduced history text size and changed datetime display to hours/weeks ago * Removed blank lines, excess styling, duplicate ChangeAction, commented lines * Changed startup/login * Added icons back in but they still require styling * All text same size * Requested changes complete * Compiled scss selectors into a nested structure * Extra namespace imports removed reday for merge Allows override target version file (Azure#8158) * allow an override FILE to be honored by test-proxy-tool * remove test-proxy-docker merge upstream main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added display to APIView to show the approval status history for the currently active revision. Included corresponding icons, date/time and reviewers who changed approval status.