Remove failure analysis and apply code cleanup #8153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
reviewed
Apr 25, 2024
| $output = Invoke "az role assignment create --assignee '$azAdGroupId' --role 'Storage Queue Data Contributor' --scope '$scope' --output none" | ||
|
|
||
| if ($LASTEXITCODE -ne 0) { | ||
| Write-Output $output |
There was a problem hiding this comment.
I'm ok with this but is there a reason you didn't put the role assignments into the bicep templates?
There was a problem hiding this comment.
The storage assignments are only needed when a dev is running the service locally and connecting to live resources. This doesn't need to be persistent access
There was a problem hiding this comment.
Also, in the pipeline, the deployment principal doesn't have permission to query Entra. We'd need to hard code the group's object id into the parameters and that didn't seem correct.
benbp
approved these changes
Apr 25, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.