Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tsp-client] Add no-prompt flag #8296

Merged
merged 2 commits into from
May 20, 2024
Merged

[tsp-client] Add no-prompt flag #8296

merged 2 commits into from
May 20, 2024

Conversation

catalinaperalta
Copy link
Member

Support --no-prompt flag to skip the output directory confirmation prompt.

@catalinaperalta catalinaperalta marked this pull request as ready for review May 17, 2024 21:00
iscai-msft
iscai-msft approved these changes May 20, 2024
View reviewed changes
Copy link

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only nit i have is if you could add why someone would use --no-prompt if this is something we want users to use. if it's more internal, no need to add any docs

@catalinaperalta catalinaperalta merged commit 2f5685c into main May 20, 2024
7 checks passed
@catalinaperalta catalinaperalta deleted the tsp-client/noprompt branch May 20, 2024 23:52
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@joheredi joheredi Awaiting requested review from joheredi

@chunyu3 chunyu3 Awaiting requested review from chunyu3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catalinaperalta @iscai-msft @cperaltah