Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tsp-client compare command #8793

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Add tsp-client compare command #8793

merged 6 commits into from
Aug 8, 2024

Conversation

tjprescott
Copy link
Member

Basically is a pass-through to the packaged openapi-diff tool.

@tjprescott tjprescott requested a review from allenjzhang August 6, 2024 20:07
@tjprescott tjprescott marked this pull request as draft August 6, 2024 20:09
@tjprescott tjprescott force-pushed the tsp-client/compareCommand branch from a9464b8 to 358c264 Compare August 6, 2024 20:13
@tjprescott tjprescott marked this pull request as ready for review August 6, 2024 20:14
catalinaperalta
catalinaperalta approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just hoping we can get an example handwritten swagger to compare against

tools/tsp-client/.gitignore Show resolved Hide resolved
tools/tsp-client/test/run_commands.ts Outdated Show resolved Hide resolved
tools/tsp-client/src/index.ts Outdated Show resolved Hide resolved
tjprescott and others added 2 commits August 8, 2024 09:33
@tjprescott
Update test.
9446bf2
@tjprescott @catalinaperalta
Update tools/tsp-client/src/index.ts
b657162 
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
@tjprescott tjprescott mentioned this pull request Aug 8, 2024
Merged
@tjprescott tjprescott merged commit ab1eacb into main Aug 8, 2024
9 checks passed
@tjprescott tjprescott deleted the tsp-client/compareCommand branch August 8, 2024 18:09
github-merge-queue bot pushed a commit to Azure/typespec-azure that referenced this pull request Aug 8, 2024
@tjprescott
Update docs for tsp-client compare (#1331)
8d46030 
Follow-up PR for Azure/azure-sdk-tools#8793

cc/ @allenjzhang
scbedd added a commit that referenced this pull request Aug 9, 2024
@scbedd
Revert "Add tsp-client compare command (#8793)"
6c1e69d 
This reverts commit ab1eacb.
scbedd added a commit that referenced this pull request Aug 9, 2024
@scbedd
Revert "Add tsp-client compare command (#8793)" + package lock adju…
b30bd53 
…stments (#8811)

* Revert "Add `tsp-client compare` command (#8793)"

This reverts commit ab1eacb.

* update package version and lock
* update changelog to reflect package version
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjprescott @catalinaperalta