Use new ADO credential type for connections over azure credentials #9058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backround workers are persistent and hold a reference to a Processor.
Processors hold VssConnections and VssConnections hold a reference to a credential. When that credential is baked around a token, the whole token -> credential -> connection -> processor -> worker chain needs to be recreated when the token expires.
We weren't doing this and the service would throw vss unauthorized exceptions when the token expired after 24 hours. Rather than reconstruct the whole chain or shim factories in the mix, we can use the preview version of the ado client libraries that support Azure Identity credentials and dynamic token requests.