Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample-automation, bug fix on wrong api version folder #9151

Merged
merged 4 commits into from
Oct 14, 2024
Merged

sample-automation, bug fix on wrong api version folder #9151

merged 4 commits into from
Oct 14, 2024

Conversation

weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Oct 14, 2024 •
edited
Loading

fix #9150

  1. raise Error, if no tsp-location.yaml found (it happens to 1 js package, it is their problem but we need to guard against this)
  2. fix bug that automation didn't scope the api-version when searching the typespec example JSON

@weidongxu-microsoft weidongxu-microsoft requested a review from a team as a code owner October 14, 2024 05:52
@weidongxu-microsoft weidongxu-microsoft merged commit 7e5d208 into main Oct 14, 2024
7 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the sample-automation_bug-fix-wrong-api-version-folder branch October 14, 2024 06:23
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaofeiCao XiaofeiCao XiaofeiCao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sample-automation] placing typespec samples in wrong api-version folder
2 participants
@weidongxu-microsoft @XiaofeiCao