Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose fullyCompatible parameter of converter #9238

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Expose fullyCompatible parameter of converter #9238

merged 8 commits into from
Oct 31, 2024

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Oct 23, 2024 •
edited
Loading

As titled.

@pshao25 pshao25 requested a review from tadelesh October 23, 2024 13:14
catalinaperalta
catalinaperalta requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also go into more detail about the flag in the readme under the section for the convert command. Otherwise folks may not know what a "fully compatible typespec" is

tools/tsp-client/src/commands.ts Outdated Show resolved Hide resolved
tools/tsp-client/src/index.ts Outdated Show resolved Hide resolved
@pshao25
Copy link
Member Author

pshao25 commented Oct 25, 2024

Can you please also go into more detail about the flag in the readme under the section for the convert command. Otherwise folks may not know what a "fully compatible typespec" is

Updated. I actually planned to update this to TypeSpec-Azure document.

catalinaperalta
catalinaperalta approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

tools/tsp-client/CHANGELOG.md Outdated Show resolved Hide resolved
tools/tsp-client/README.md Outdated Show resolved Hide resolved
pshao25 and others added 3 commits October 26, 2024 12:03
@pshao25 @catalinaperalta
Update tools/tsp-client/CHANGELOG.md
7c6164d 
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
@pshao25 @catalinaperalta
Update tools/tsp-client/README.md
537042b 
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
@pshao25
update
7fbbd60
@pshao25
Copy link
Member Author

pshao25 commented Oct 31, 2024

/check-enforcer override

@pshao25 pshao25 merged commit 9b3e202 into main Oct 31, 2024
6 checks passed
@pshao25 pshao25 deleted the exposeParamter branch October 31, 2024 05:24
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@catalinaperalta catalinaperalta catalinaperalta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pshao25 @tadelesh @catalinaperalta