Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will work as-is, with a lot of reduction of complexity over in azure-sdk-for-js.
But frankly, users will have to ensure that whatever the update script is doing does not need inputs. This isn't a perfect solution, as users will have to ensure all the input to their script is available on disk or in environment variables.
Ben proposed offline the concept of a new extension on top of the existing matrix IL. Something along the lines of
If we honored the above, then what we'd do is update the
pullrequest
build matrix pull from a definition like above. We will still need to do a pregeneration matrix update to populate that dynamic setting with the package lists from the current run.If we went this route, then there wouldn't be custom code to assign to the output matrix in each repo, however we would lose access to any custom logic (like we'd use for direct/indirect packages). My js - pullrequest PR has a working implementation with a heavily stripped down
distribute-packages-to-matrix
.