Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostGeneration script #9258

Closed
wants to merge 2 commits into from
Closed

Add PostGeneration script #9258

wants to merge 2 commits into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Oct 26, 2024

This PR will work as-is, with a lot of reduction of complexity over in azure-sdk-for-js.

But frankly, users will have to ensure that whatever the update script is doing does not need inputs. This isn't a perfect solution, as users will have to ensure all the input to their script is available on disk or in environment variables.

Ben proposed offline the concept of a new extension on top of the existing matrix IL. Something along the lines of

{
  "matrix": {
    "$SPARSEIMPORT": "<matrix file>",
    // this would just offer full matrix multiplication by the below package list
    "DynamicSetting": ["<pkg list 1>", "<pkg list 2>"]
  }
}

If we honored the above, then what we'd do is update the pullrequest build matrix pull from a definition like above. We will still need to do a pregeneration matrix update to populate that dynamic setting with the package lists from the current run.

If we went this route, then there wouldn't be custom code to assign to the output matrix in each repo, however we would lose access to any custom logic (like we'd use for direct/indirect packages). My js - pullrequest PR has a working implementation with a heavily stripped down distribute-packages-to-matrix.

@scbedd scbedd self-assigned this Oct 26, 2024
@scbedd scbedd requested a review from a team as a code owner October 26, 2024 00:19
@scbedd
Copy link
Member Author

scbedd commented Oct 30, 2024

This PR has been supplanted by a better proposal in #9281

@scbedd scbedd closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant